Add Proxmox VE stats for VMs and LXCs

[morgendagen]

Fixes #281

Some environment variables must be added to the agent (I will create a separate PR for beszel-docs):

• PROXMOX_URL: url to PVE api, defaults to https://localhost:8006/api2/json
• PROXMOX_NODE: name of proxmox node to monitor
• PROXMOX_TOKENID: API token id, e.g. root@pam!beszel
• PROXMOX_SECRET: API token secret

I have not looked in to minimum requirements for the API token permissions, and am currently using one with admin access to /. I will add minimum requirements to the documentation when I have figured them out.

Proxmox server certificate vertification is currently skipped. Maybe it would make sense to add this as an option using an environment variable?

[henrygd]

Thanks so much! I really appreciate your work on this.

I think skipping cert validation is fine as the default behavior since traffic should be on the same machine with scoped permissions. I can add an option for supplying a cert later.

I'm hoping to have a release out this week, then we can shoot for including this in the following release. I don't have a proxmox machine ready to test, so I need to install it on an old laptop when I have time 👍

[morgendagen]

Thank you for creating Beszel, @henrygd. Agree on the certificate verification and release schedule.

Since Beszel is currently showing stats for a single computer, I have added a PROXMOX_NODE environment variable that must be set to the node's name in order to only show stats for a single proxmox node - I figured this would make most sense.

CPU stats did not take in to account the number of CPUs assigned to the VM or LXC. This results in graphs where the system's CPU stat will show one set of values whereas the Proxmox CPU stats may show much larger values. I believe this should be normalised so that the two graphs can be compared. I have pushed a fix for this as well.

[kamilkosek]

Hi @morgendagen , I think the PVEAuditor role with propagation on the top level should be enough.

[morgendagen]

Hi @morgendagen , I think the PVEAuditor role with propagation on the top level should be enough.

Thank you, I just tested it and it works fine.

[henrygd]

Sorry for the delay. Next release will likely be out tomorrow, then this and #579 are my top priorities.

Please don't worry about the conflicts if it's anything major. I can handle it when I merge.

[morgendagen]

I really love the idea of this, is there any specific reason, one has to use ENV-vars to add a pve host and not directly via like a checkbox or another section in the add-system UI?

Thank you for the comments.

I followed the existing design where agents are configured using environment variables. I like it as is, and do not think any changes to the current agent configuration setup should be handled in this PR.

What about promox clusters? Can I specifiy multiple nodes?

As I see it beszel is focused on single-computer statistics, which is why you need to specify a node. But this restriction could easily be lifted. I will let @henrygd decide.

Thanks!!

Happy to help :-)

[CrazyWolf13]

@henrygd
Hi
any news on this PR?

[henrygd]

@CrazyWolf13 Please see here: #579 (comment) I haven't had much time recently but there will be another release very soon. After that I'll probably disable notifications and focus on these two PRs until I get them merged.

[lotamaster]

this would be amazing - anything I can do to help get this across the finish line?

[RealFascinated]

This would be very nice to see implemented :)

[AuthorShin]

With this are we pushing for something like Pulse?

[henrygd]

@AuthorShin That's a cool project. This will be a little more basic (at least initially).

I apologize again for taking so long with this. I have not forgotten about it.

[dzidulajubilee]

I wonder why this is taking so long, @henrygd , I was beginning to think you forgot about this.

[weeebdev]

Just pinging to check if the PR still matters. I'd love this to be merged, as I do not want to setup Pulse across the whole pmx cluster.

[henrygd]

Got myself a mini PC for Christmas to use as a dedicated Proxmox machine. So I'll try to get this finished at some point in January. Sorry again for the wait!

[SeaweedbrainCY]

Please, don't apologize, your work is astonishing.

I believe we are many people in the Beszel community using proxmox, do not hesitate to ping if you need some beta testers on proxmox !