adding reading agent ssh key from file#412
Merged
henrygd merged 1 commit intohenrygd:mainfrom Jan 16, 2025
Merged
Conversation
Closed
devil1234
reviewed
Jan 16, 2025
| log.Fatalf("Failed to read key from file '%s': %v", keyFile, err) | ||
| } | ||
| } else { | ||
| log.Fatal("KEY environment variable is not set, and KEY_FILE environment variable is not set") |
There was a problem hiding this comment.
I think should be changed to : KEY environment variable is not set or KEY_FILE environment variable is not set
Owner
There was a problem hiding this comment.
I changed it to "Must set KEY or KEY_FILE environment variable." Slightly more concise.
Owner
|
Merged, thanks 👍 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading the agent SSH key from a file. This allows storing the agent key as a docker secret.
I'm not a Go dev so let me know if there's a better way to do this but it's pretty straightforward