Repository navigation
Fix the Fable review findings for the 32ecd71726 sync - #287
Merged
Merged
Conversation
- docs/user/source-control.md: commit links outside the workspace show an Open link button; the fork has no "Open links in" setting and GitLab's definition parses no merge request commit URLs. - client-runtime: take upstream's ./state/thread-history-merge export; the module is carried, so dropping only the entry was unlisted drift. - ProviderInstanceCard: restore upstream's readOnly gate on the version action (pre-existing unlisted drift). - coder-only.md: list ProviderSettingsPanel's dropped secret sources and ChatHeader's desktopBridge check; GitLabCli fixes checked against 32ecd71 (upstream's GitLabCli is unchanged since 67661cf). - sync.md: the new macOS TMPDIR test result, reading the suite's own exit status, and the new DELETED_PATHS categories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the findings from a three-reviewer Fable 5.1 review (server, web, seams/tooling) of the sync in #285 and #286. The reviewers found no merge losses, wrong resolutions, or boundary problems.
Fixed
docs/user/source-control.mddescribed an "Open links in" setting the fork doesn't have, and a merge request commit-link path that GitLab's definition can't take. It now says what T3 Coder actually does../state/thread-history-mergeexport in client-runtime. The module is carried, so dropping only its export entry was drift the seams doc doesn't list.readOnlygate on the version action inProviderInstanceCard(pre-existing drift the seams doc doesn't list).coder-only.mdnow lists:ProviderSettingsPanel's dropped secret sources;ChatHeader'sdesktopBridgecheck;sync.mdnow records the macOSTMPDIRresult for a new upstream test, says to read the suite's own exit status, and lists the newDELETED_PATHScategories.Left as is
secretProviderSettings: trueis still advertised. This was the documented choice to keep upstream's settings plumbing; nothing carried reads it.RestartContinuationkeeps "T3 Code" too).Verification:
typecheck:web, the client-runtime typecheck,ProviderInstanceCard.test.ts,knip:check, andvp fmt --checkall pass.🤖 Generated with Claude Code