Repository navigation
Open changed files from the Git actions dialog in Files - #270
Merged
Merged
Conversation
GitActionsControl's onOpenFile seam was never passed by its only caller, so the dialog's changed-file buttons were always disabled. ChatView now passes openFileSurfaceStable through ThreadDetailsPanel, and the dialog closes after opening a file so the Files surface is visible; its commit message stays for the next open. The button regains an accessible label. Fixes #265 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265.
Cause:
GitActionsControl'sonOpenFileseam (changed files open in the Files surface rather than an editor) was added without wiring its only caller.ThreadDetailsPanelnever passed the prop, so the commit dialog's changed-file buttons were always disabled.Fix:
ChatViewpassesopenFileSurfaceStablethroughThreadDetailsPanel's newonOpenFileprop, for server threads.Verification:
pnpm typecheck:web,pnpm knip:checkandvp fmt --checkpass.components/chat,GitActionsControl.logic,ChatView.logic).file.tscalledonOpenFile("file.ts")and closed the dialog, and without the prop the button stays disabled.🤖 Generated with Claude Code