Repository navigation
Align ChatMarkdown and FilePreviewPanel with upstream's compiled form - #205
Merged
Merged
Conversation
A hunk-by-hunk read of the six fork-heavy web files against upstream 13aa882 (assetUrls, HtmlRenderFrame, AttachmentFilePreview, RightPanelTabs, FilePreviewPanel, ChatMarkdown) found no missing upstream behaviour beyond the documented cuts, but two files still carried pre-compiler shape that upstream removed in the React Compiler rollout: - ChatMarkdown: 31 useCallback/useMemo wrappers are gone, as upstream's are; `brandLinkIcon` is upstream's `isGitHubHost` again; the dead `MarkdownAstNode` type and `isWindowsAbsolutePath` import are removed; and the lucide and session imports sit in the import block. - FilePreviewPanel: 15 wrappers are gone, including the fork-only ones around `owner`, `handlePendingChange`, and `reloadFile`, and upstream's exhaustive-deps lint note on the breadcrumb scroll effect is back. Every Coder seam in both files is unchanged. ChatView's rewind now reads a message's images concurrently, as upstream's prepareRevertedMessageAttachments fetches them, and creates preview URLs only after every read has succeeded. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the sync review (#204): a hunk-by-hunk read of the six fork-heavy web files against upstream 13aa882.
Result of the read
assetUrls,HtmlRenderFrame,AttachmentFilePreview: every difference is the helper-read seam. Nothing missing.RightPanelTabs: differs only by the cut browser/device/preview surfaces and the deliberately uncarried perf(web): right panel tabs no longer all re-render on unrelated chat updates pingdotgg/t3code#20853 per-tab memo.ChatMarkdownandFilePreviewPanel: no missing upstream behaviour, but both still carried the manual memoization upstream removed in the React Compiler rollout (stage 2 kept these files from the fork's side and skipped those hunks).Changes
ChatMarkdown: 31useCallback/useMemowrappers removed to match upstream;brandLinkIcon→ upstream'sisGitHubHost; deadMarkdownAstNodetype andisWindowsAbsolutePathimport removed; stray lucide/session imports moved into the import block.FilePreviewPanel: 15 wrappers removed (including the fork-only ones aroundowner,handlePendingChange,reloadFile); upstream's exhaustive-deps lint note restored.ChatView: rewind reads a message's images concurrently (as upstream'sprepareRevertedMessageAttachmentsdoes) and creates preview URLs only after all reads succeed.Every
Coder:seam in the touched files is unchanged; a fork-line check against the previous versions confirmed only wrapper/deps lines and the items above were removed.Verification:
typecheck:web,vp fmt --check,reactCompilerCoverageand the fulltest:web:codersuite (393 files / 6201 tests, browser project included) pass.🤖 Generated with Claude Code