Skip to content

fix(analyze): make FTS index creation non-fatal during analyze #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henry201605 wants to merge 1 commit into from
Closed

fix(analyze): make FTS index creation non-fatal during analyze #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 22 additions & 15 deletions gitnexus/src/core/run-analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,22 +669,29 @@ export async function runFullAnalysis(

// ── Phase 3: FTS (85–90%) ─────────────────────────────────────────
progress('fts', 85, 'Creating search indexes...');
await createSearchFTSIndexes({
onIndexStart: options.verbose
? (table, indexName) => log(`FTS: creating ${table}.${indexName}`)
: undefined,
onIndexReady: options.verbose
? (table, indexName) => log(`FTS: ready ${table}.${indexName}`)
: undefined,
});
const missingIndexNames = await verifySearchFTSIndexes(executeQuery);
if (missingIndexNames.length > 0) {
throw new Error(
`FTS verification failed - missing indexes after analyze: ${missingIndexNames.join(', ')}. ` +
'Check FTS extension availability, then retry `gitnexus analyze --force` for a full rebuild.',
);
try {
await createSearchFTSIndexes({
onIndexStart: options.verbose
? (table, indexName) => log(`FTS: creating ${table}.${indexName}`)
: undefined,
onIndexReady: options.verbose
? (table, indexName) => log(`FTS: ready ${table}.${indexName}`)
: undefined,
});
const missingIndexNames = await verifySearchFTSIndexes(executeQuery);
if (missingIndexNames.length > 0) {
log(
`⚠️ FTS verification warning - missing indexes: ${missingIndexNames.join(', ')}. ` +
'BM25 keyword search will be degraded. Upgrade macOS or run on a compatible platform to enable FTS.',
);
} else {
progress('fts', 90, 'Search indexes ready');
}
} catch (ftsErr: unknown) {
const ftsMsg = ftsErr instanceof Error ? ftsErr.message : String(ftsErr);
log(`⚠️ FTS creation skipped (non-fatal): ${ftsMsg}`);
progress('fts', 90, 'Search indexes skipped (FTS unavailable)');
}
progress('fts', 90, 'Search indexes ready');

// ── Phase 3.5: Re-insert cached embeddings ────────────────────────
// Runs on BOTH the full-rebuild path and the incremental path:
Expand Down