Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: add command-line options to set perf event buffer size #247

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

mannkafai
Copy link
Contributor

@mannkafai mannkafai commented Jan 5, 2025

add syscall-perf-event-map-page-num, ssl-perf-event-map-page-num, conn-perf-event-map-page-num, kern-perf-event-map-page-num command-line options to set pageNum of SyscallDataEvents, SslDataEvents, ConnDataEvents and KernEvents.

This will fix #245

add  `syscall-mapsize` , `ssl-mapsize`, `conn-mapsize`,  `kern-mapsize` command-line options to set `pageNum` of  `PullSyscallDataEvents`, `PullSslDataEvents`, `PullConnDataEvents` and `PullKernEvents`.
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kyanos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 6:38am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 5, 2025
agent/common/options.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/common.go Outdated Show resolved Hide resolved
agent/common/options.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@hengyoush
Copy link
Owner

Thank you for your contribution! There are some comments you can check out.

add `syscall-perf-event-map-page-num`, `ssl-perf-event-map-page-num`, `conn-perf-event-map-page-num`, `kern-perf-event-map-page-num` command-line options to set pageNum of `SyscallDataEvents`, `SslDataEvents`, `ConnDataEvents` and `KernEvents`.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 5, 2025
Copy link
Owner

@hengyoush hengyoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2025
@hengyoush hengyoush merged commit 141c810 into hengyoush:main Jan 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make perf event buffer pageNum configurable instead of hard-coded
2 participants