Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: introduce a script to test flag --comm #222

Merged
merged 6 commits into from
Dec 31, 2024
Merged

test: introduce a script to test flag --comm #222

merged 6 commits into from
Dec 31, 2024

Conversation

spencercjh
Copy link
Contributor

CLOSE #212

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kyanos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 3:46am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 27, 2024
@spencercjh spencercjh changed the title test: introduce test_filter_by_comm.sh to test flag --comm test: introduce a script to test flag --comm Dec 27, 2024
@dosubot dosubot bot added the unittest label Dec 27, 2024
@spencercjh spencercjh marked this pull request as draft December 27, 2024 08:59
@spencercjh spencercjh marked this pull request as ready for review December 27, 2024 09:55
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 27, 2024
@hengyoush
Copy link
Owner

HTTPS may require sending more than two requests over a long connection to be correctly captured 😂.
Can this test be simplified by using curl to request any website (via http), and then using --comm curl? Finally check, when grepping, filter for the domain name (e.g., if curl requests baidu, grep for baidu.com).

What do you think? @spencercjh

@spencercjh
Copy link
Contributor Author

HTTPS may require sending more than two requests over a long connection to be correctly captured 😂.

Can this test be simplified by using curl to request any website (via http), and then using --comm curl? Finally check, when grepping, filter for the domain name (e.g., if curl requests baidu, grep for baidu.com).

What do you think? @spencercjh

OK 👌

@spencercjh
Copy link
Contributor Author

We could use " http://ipinfo.io" to test, because response of github.com is too big.

It's amazing, the test doesn't report the occasional error after I changed it as you said. Why is that?

@hengyoush
Copy link
Owner

We could use " http://ipinfo.io" to test, because response of github.com is too big.

It's amazing, the test doesn't report the occasional error after I changed it as you said. Why is that?

May be some bug 😨, huge response may cause some error, i need to take a closer look. Thank you for spotting the problem!

@hengyoush
Copy link
Owner

It seems to have failed again, there should be a bug. I may need to analyze the case of the client side again. You can comment out the case of the client side and only run the case of the server side.😂

hengyoush
hengyoush approved these changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@hengyoush hengyoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2024
@hengyoush hengyoush merged commit 1434c4d into hengyoush:main Dec 31, 2024
15 checks passed
@spencercjh spencercjh deleted the test/filter-by-comm branch December 31, 2024 04:30
XmchxUp pushed a commit to XmchxUp/kyanos that referenced this pull request Dec 31, 2024
@spencercjh @XmchxUp
test: introduce a script to test flag --comm (hengyoush#222)
537a08a
@hengyoush hengyoush mentioned this pull request Jan 1, 2025
Merged
hengyoush pushed a commit that referenced this pull request Jan 6, 2025
@spencercjh @hengyoush
test: introduce a script to test flag --comm (#222)
49dac8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

@hengyoush hengyoush hengyoush approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. unittest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an e2e test to verify the --comm option works fine
3 participants
@spencercjh @hengyoush @ccoVeille