-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce a new workflow to verify build script on multi platforms #196
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
test.yml
test
and format
steps to test.yml
Thanks for your contribution! Here are some suggestions I have:
What do you think? |
You're right. Also I have to take some time to get a working Ubuntu workspace.😅 |
test
and format
steps to test.yml
test
and format
steps to test.yml
test
and format
steps to test.yml
test
and format
steps to test.yml
1a36810
to
d6b0889
Compare
test
and format
steps to test.yml
3f55be0
to
fcc71d0
Compare
I attempted to implement your suggestions, but I found that the free version on GitHub (as opposed to the Team and Enterprise versions) does not support ARM64 runners: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners |
Lines 11 to 30 in 4be0227
The Ubuntu version here doesn't exactly match the Ubuntu version in the runner provided by GitHub. You need to open another PR to change it. I'm sorry that I don't really understand the constraints of these distro and CLANG versions. That's why the test for ubuntu-20.04 fails now. |
To minimize the size of this PR, the workflow that governs the formatting and style of the code should be placed in a separate workflow yaml file. |
Just add one check: if [ ${release_num} == "20.04" ]; then
CLANG_NUM=-10 I tested it on Ubuntu 20.04 and it works fine. @spencercjh |
Signed-off-by: spencercjh <[email protected]>
Signed-off-by: spencercjh <[email protected]>
Signed-off-by: spencercjh <[email protected]>
Signed-off-by: spencercjh <[email protected]>
Signed-off-by: spencercjh <[email protected]>
Signed-off-by: spencercjh <[email protected]>
934cae4
to
887efce
Compare
…rms (#196) * feat: introduce new Check workflow * fix: correct matrix * fix: Make different matrices run independently of each other * test: test init_env in the step * style: resolve fmt issues Signed-off-by: spencercjh <[email protected]> * chore: simplify matrix Signed-off-by: spencercjh <[email protected]> * chore: rename the wf Signed-off-by: spencercjh <[email protected]> * chore: remove irrelevant codes to check format issues Signed-off-by: spencercjh <[email protected]> * fix: add missing build step Signed-off-by: spencercjh <[email protected]> * fix: add missing clang_num init biz for ubuntu 20.04 Signed-off-by: spencercjh <[email protected]> --------- Signed-off-by: spencercjh <[email protected]>
CLOSE #176