Allow config of init height for tbc#6
Merged
ClaytonNorthey92 merged 4 commits intohemifrom Jun 7, 2024
Merged
Conversation
ClaytonNorthey92
requested review from
jcvernaleo,
joshuasing,
marcopeereboom and
max-sanchez
joshuasing
approved these changes
Jun 4, 2024
joshuasing
reviewed
Jun 4, 2024
cmd/geth/main.go
Outdated
|
|
||
| var initHeight uint64 | ||
| initHeight = 2585811 // Temp for testing, this should be part of chain config | ||
| var initHeight uint64 = 2585811 |
There was a problem hiding this comment.
Could we make this variable a global constant? 🤔
ClaytonNorthey92
added a commit
that referenced
this pull request
Apr 1, 2025
* Add pop transaction type * Copyright * Add version * Add PoP tx type version and add it to valid transaction types * Start sprinkling pop tx * re-added Value to PopTx.copy(), added test, added todo comment * Disable test that won't work with reflect due to pointers * Changed PoPTx to PoPPayoutTx, and replaced the PoP data fields (raw Bitcoin tx bytes, Merkle path, containing Bitcoin block, etc.); rather than carrying full PoP data the PoPPayoutTx just performs the actual payouts by calling GovernanceToken.mintPoPRewards(). * - Prevent l1 fees from being set or re-derived for PoP Txes in transaction receipts - Add popPayoutNonce field similar to depositNonce in Deposit Txes - Nonce for PoP transactions set automatically during state transition similar to Deposit Txes - * Remove "Version" from PoP Payout Tx * Misc. Fixes & TODOs Resolved - Added PoP Payout Nonce serialization to RPCTransaction - Added checks to PoP Tx Unmarshalling for fields that shouldn't be set - Removed unset fields from PoP Tx copy - Added PoPPayoutNonce serialization to receipt marshalling - Confirmed only Sender() method on EIP2930Signer needs to process PoP Payout sender correctly - Fixed RPC PoP Tx deserialization test * Fixed Non-Typed RLP Encode/Decode Added PoPPayoutTx to Receipt tests * Fixed Non-Typed RLP Encode/Decode Added PoPPayoutTx to Receipt tests * Removed unused Nonce, IsSystemTransaction, and Value fields from PoP Tx Implemented TestPopPayoutTxEncodeDecode * Fixed merge bug * Regenerated gen_receipt_json.go --------- Co-authored-by: ClaytonNorthey92 <clayton.northey@gmail.com> Co-authored-by: Max Sanchez <max@veriblock.com> Co-authored-by: Maxwell Sanchez <macbymax@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow configuration of init height for tbc