hVM Phase 0 Error Handling & Misc Cleanup#3
Merged
max-sanchez merged 2 commits intohemifrom May 2, 2024
Merged
Conversation
max-sanchez
commented
Apr 17, 2024
max-sanchez
commented
- Updated initHeight for new testnet deployment
- Removed old Postgres hVM database stuff
- Converted log.Crits put in for debugging to Errors
- Fixed blockhash order in transaction return
- Modified transaction returned to not include non-spendable output amounts if caller requests non-spendables be ignored
- Implemented script chopping
Updated precompile contract error handling Removed old Postgres hVM database access Updated transactionByTxID enabled bitflags Updated initHeight for testnet redeployment
Reversed BTC hash in transaction Output value in transaction not placed if it's unspendable and tx request doesn't want unspendable outputs listed
max-sanchez
requested review from
ClaytonNorthey92,
joshuasing and
marcopeereboom
joshuasing
reviewed
Apr 17, 2024
| log.Error("Unable to retrieve tip headers from TBC", "err", err) | ||
| return | ||
| } | ||
| log.Info(fmt.Sprintf("TBC download status: tipHeight=%d", tipHeight)) |
There was a problem hiding this comment.
I think key/value pairs could be used for consistency here instead of using Sprintf - unless there's a reason not to? 🤔
Suggested change
| log.Info(fmt.Sprintf("TBC download status: tipHeight=%d", tipHeight)) | |
| log.Info("TBC download status", "tipHeight", tipHeight) |
|
hey @max-sanchez I am testing this now, hang tight, there is something funny, I am not sure if it is this PR or something else |
ah it's tbc syncing |
ClaytonNorthey92
pushed a commit
that referenced
this pull request
Nov 13, 2025
This PR is #3 of a 3-part series that implements the new log index intended to replace core/bloombits. Based on ethereum/go-ethereum#31079 and ethereum/go-ethereum#31080 Replaces ethereum/go-ethereum#30370 This part removes the old bloombits package and the chain indexer that was only used by bloombits. Deletes the old bloombits database. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
ClaytonNorthey92
pushed a commit
that referenced
this pull request
Dec 16, 2025
This PR is #3 of a 3-part series that implements the new log index intended to replace core/bloombits. Based on ethereum/go-ethereum#31079 and ethereum/go-ethereum#31080 Replaces ethereum/go-ethereum#30370 This part removes the old bloombits package and the chain indexer that was only used by bloombits. Deletes the old bloombits database. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.