Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bfgd, electrumx: make initial and max conns configurable #206

Merged
merged 2 commits into from
Aug 21, 2024
Merged

bfgd, electrumx: make initial and max conns configurable #206

merged 2 commits into from
Aug 21, 2024

Conversation

joshuasing
Copy link
Contributor

Summary
Add environment variables to BFG for configuring the initial and maximum connections for the ElectrumX client's connection pool.

Resolves #205

Changes

  • Add initialConns and maxConns params to electrumx.NewClient
  • Add EXBTCInitialConns and EXBTCMaxConns fields to BFG config
  • Add BFG_EXBTC_INITIAL_CONNECTIONS and BFG_EXBTC_MAX_CONNS to BFG
  • Sync environment variables in BFG Dockerfile

@joshuasing joshuasing added type: refactor This refactors existing functionality status: breaking This is a breaking and non-backwards compatible change size: S This change is small (+/- <80) labels Aug 15, 2024
@joshuasing joshuasing requested a review from a team as a code owner August 15, 2024 20:02
@github-actions github-actions bot added area: bfg This is a change to BFG (Bitcoin Finality Governor) area: docker This is a change to a Dockerfile labels Aug 15, 2024
@joshuasing joshuasing force-pushed the joshua/bfgd-electrumx-configurable branch from c43ca22 to 447b0f5 Compare August 15, 2024 20:17
ClaytonNorthey92
ClaytonNorthey92 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ClaytonNorthey92 ClaytonNorthey92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asking to remove/move some variables, not blocking

hemi/electrumx/electrumx.go Show resolved Hide resolved
@joshuasing joshuasing merged commit 6b21809 into main Aug 21, 2024
6 checks passed
@joshuasing joshuasing deleted the joshua/bfgd-electrumx-configurable branch August 21, 2024 18:37
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
bfgd, electrumx: make initial and max conns configurable (hemilabs#206)
3088c02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@marcopeereboom marcopeereboom marcopeereboom approved these changes

@jcvernaleo jcvernaleo Awaiting requested review from jcvernaleo

@max-sanchez max-sanchez Awaiting requested review from max-sanchez

Assignees
No one assigned
Labels
area: bfg This is a change to BFG (Bitcoin Finality Governor) area: docker This is a change to a Dockerfile size: S This change is small (+/- <80) status: breaking This is a breaking and non-backwards compatible change type: refactor This refactors existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bfgd, electrumx: make conn pool maximum size configurable
3 participants
@joshuasing @marcopeereboom @ClaytonNorthey92