fix(Server): handle finished responses in onError

helperdiscord · May 4, 2020 · 1166e91 · 1166e91
1 parent 74ac1a8
commit 1166e91
Show file tree

Hide file tree

Showing 3 changed files with 534 additions and 484 deletions.
diff --git a/package.json b/package.json
@@ -15,8 +15,8 @@
     "url": "https://github.com/dirigeants/klasa-dashboard-hooks.git"
   },
   "scripts": {
-    "lint": "npx eslint --fix src && npx eslint --fix --config .eslintrcmd.json --ext md guides && npx tslint --fix 'typings/*.ts'",
-    "test:lint": "npx eslint src && npx tslint 'typings/*.ts' && npx eslint --config .eslintrcmd.json --ext md guides && npx markdownlint guides README.md",
+    "lint": "npx eslint --fix src && npx eslint --fix --config .eslintrcmd.json --ext md guides",
+    "test:lint": "npx eslint src && npx eslint --config .eslintrcmd.json --ext md guides && npx markdownlint guides README.md",
     "docs": "npx dg --source src --custom guides/.docconfig.json --output dist/docs.json --logging"
   },
   "dependencies": {
@@ -33,7 +33,6 @@
     "eslint-config-klasa": "github:dirigeants/klasa-lint",
     "eslint-plugin-markdown": "^1.0.0",
     "markdownlint-cli": "^0.17.0",
-    "tslint": "^5.16.0",
     "typescript": "^3.6.3"
   },
   "engines": {

diff --git a/src/lib/http/Server.js b/src/lib/http/Server.js
@@ -108,6 +108,11 @@ class Server {
 	 * @param {external:ServerResponse} response The response
 	 */
 	onError(error, request, response) {
+		if (response.finished) {
+			this.client.emit('error', error);
+			return;
+		}
+
 		const code = response.statusCode = error.code || error.status || error.statusCode || 500;
 		response.end((error.length && error) || error.message || http.STATUS_CODES[code]);
 	}