Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hpkp from helmet #192

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Remove hpkp from helmet #192

merged 2 commits into from
Jun 13, 2019

Conversation

gzog
Copy link
Contributor

@gzog gzog commented May 26, 2019

Resolves #180

@gzog gzog changed the title Remove hpkp form helmet Remove hpkp from helmet May 26, 2019
EvanHahn
EvanHahn requested changes May 26, 2019
View reviewed changes
Copy link
Member

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and will be included in helmet@4.

I think package-lock.json should have changed here. If that's the case, could you update it?

@EvanHahn EvanHahn changed the base branch from master to 4.x June 13, 2019 21:37
EvanHahn
EvanHahn approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging into the 4.x branch now.

@EvanHahn EvanHahn merged commit 02940a0 into helmetjs:4.x Jun 13, 2019
This was referenced Jun 12, 2020
Merged
Closed
EvanHahn pushed a commit that referenced this pull request Jun 12, 2020
@gzog @EvanHahn
Remove hpkp from helmet
32060a5 
See [#192](#192).
EvanHahn pushed a commit that referenced this pull request Jun 29, 2020
@gzog @EvanHahn
Remove hpkp from helmet
61fe8a3 
See [#192](#192).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzog @EvanHahn