Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noCache from "mainline" Helmet #215

Closed
EvanHahn opened this issue Mar 20, 2020 · 5 comments
Closed

Remove noCache from "mainline" Helmet #215

EvanHahn opened this issue Mar 20, 2020 · 5 comments
Assignees
Milestone

Comments

@EvanHahn
Copy link
Member

EvanHahn commented Mar 20, 2020

In an effort to focus this project's scope, I'm trying to make sure that Helmet only focuses on HTTP response headers that are strictly related to security. While nocache is useful, it's not strictly security-related in my eyes, so I'm removing it.

This functionality isn't going away. It's just moving to a separate module, nocache. You can find it on npm and on GitHub.

Instead of this:

const helmet = require('helmet')
// ...
app.use(helmet.noCache())

You'll do this:

const noCache = require('nocache')
// ...
app.use(noCache())

This is a breaking change that will be part of Helmet 4.

@EvanHahn EvanHahn self-assigned this Mar 20, 2020
@unbalanced
Copy link

Hey, can you refer me to information on why it was removed from the "default" settings and will be removed in Helmet 4?

Thanks

@EvanHahn
Copy link
Member Author

In an effort to focus this project's scope, I'm trying to make sure that Helmet only focuses on HTTP response headers that are strictly related to security. While nocache is useful, it's not strictly security-related in my eyes, so I'm removing it.

This functionality isn't going away. It's just moving to a separate module, nocache.

@JEstradaDev
Copy link

hi!! could you add the link for nocache module or new documentation?? please

thanks.

@EvanHahn
Copy link
Member Author

@JEstradaDev Good idea. I've added more information to the description of this issue.

@EvanHahn EvanHahn added this to the 4.0.0 milestone Jun 12, 2020
@EvanHahn EvanHahn mentioned this issue Jun 12, 2020
36 tasks
EvanHahn added a commit that referenced this issue Jun 12, 2020
Closes [#215][0].

[0]: #215
@EvanHahn
Copy link
Member Author

This was done in ca483bd and merged into the upcoming v4 branch (see #197).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants