s.getParser was broken because of import * as bowser from 'bowser';

[dagda1]

I had the dreaded error:

s.getParser is not a function

On investigation, it was because bowser was coming in as a * import and esModuleInterop is set to true in tsconfig.json which negates the need to use the import * import.

So my PR changes it to:

import bower from 'bowser'`

This will fix the problem.

[dagda1]

This is breaking on node 6. Should you really be supporting node 6?

[EvanHahn]

I just pushed up a change that disables Node 6 on CI. Could you try rebasing (or merging) to see if that fixes your problem? (I consider it a breaking change to drop support for Node versions, even if those versions are deprecated. I plan to release a breaking change to this module in the coming months that requires Node 10+.)

[dagda1]

@EvanHahn rebased and all good. Cheers!

[dagda1]

@EvanHahn do you want me to bump the version?

[EvanHahn]

Looks great! I'll update bowser and release a new version of this module soon.

[EvanHahn]

This should be released in [email protected]. I'll add it to "mainline" Helmet in the next two days once I've confirmed everything works.

[EvanHahn]

Also, feel free to add yourself to the contributors list.

[EvanHahn]

This has been released in [email protected]. Thanks again!

[dagda1]

@EvanHahn if there is anything else i can do and especially of a typescript nature then let me know