Create HIP for alternative delimiter feature #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neer Friedman <[email protected]>
neerfri
force-pushed
the
alternative-delimiter-feature
branch
from
dc33bc1
to
e5a28e1
Compare
5 tasks
* use modifier `delimiters=` instead of `delim=` * specify full delimiters instead of duplicating the delimiter (`[,]` -> `[[,]]`) * document the Template Header concept Signed-off-by: Neer Friedman <[email protected]>
neerfri
force-pushed
the
alternative-delimiter-feature
branch
from
3bc2df9
to
db0fe3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tools use templating syntax with {{ ... }} delimiters, it's hard to maintain Helm charts for such tools.
This HIP suggests to use "magic comments" in the template to control the delimiter.
Signed-off-by: Neer Friedman [email protected]