-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/redis] Update labelling strategy #9332
Conversation
Signed-off-by: Eric Bailey <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yurrriq If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yurrriq. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Use [recommended labels][1] via newly created named templates - Rename a few labels to be more specific - `role: metrics` -> `app.kubernetes.io/component: metrics` - `role: master` -> `redis.io/role: master` - `role: slave` -> `redis.io/role: slave` [1]: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Eric Bailey <[email protected]>
/assign @juan131 |
Should we discuss this during the next meeting? #7696 has been closed due to lack of activity. |
I could join the discussion on 11/29. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a breaking change for people operating Redis because the matchLabels and volume lablels change. A painful change just for labels is one I'm not sure I want to put forth.
It may make more sense to do this when it moves to the distributed search and some other large changes land.
{{ include "redis.instance-name" . }} | ||
app.kubernetes.io/managed-by: {{ .Release.Service | quote }} | ||
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
helm.sh/chart: {{ include "redis.chart" . | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a neat method to avoid repeating the same things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance this could be made the default?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
What this PR does / why we need it:
home
inChart.yaml
to usehttps://
Checklist