This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/redis] Do not set annotation field if there is no annotation in master service #7786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ey-bot
added
the
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
label
Sep 18, 2018
k8s-ci-robot
added
the
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Sep 18, 2018
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 18, 2018
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 24, 2018
I think we can unhold this PR and rebase from master to continue working on it. /hold cancel |
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
label
Sep 24, 2018
Signed-off-by: Cédric de Saint Martin <[email protected]>
ey-bot
added
the
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
label
Sep 24, 2018
I was just doing it! Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Sep 24, 2018
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
…helm#7786) Signed-off-by: Cédric de Saint Martin <[email protected]> Signed-off-by: jenkin-x <[email protected]>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…helm#7786) Signed-off-by: Cédric de Saint Martin <[email protected]> Signed-off-by: Jakob Niggel <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…helm#7786) Signed-off-by: Cédric de Saint Martin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
lgtm
Indicates that a PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Annotation field in master service is always set even if empty. This does not validate against validation tools like kubeval.