Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/redis] Do not set annotation field if there is no annotation in master service #7786

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Conversation

desaintmartin
Copy link
Collaborator

What this PR does / why we need it:

Annotation field in master service is always set even if empty. This does not validate against validation tools like kubeval.

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 18, 2018
@desaintmartin
Copy link
Collaborator Author

/hold
Waiting for #7686 to be fixed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2018
@desaintmartin
Copy link
Collaborator Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2018
@juan131
Copy link
Collaborator

juan131 commented Sep 24, 2018

Hi @desaintmartin

I think we can unhold this PR and rebase from master to continue working on it.

/hold cancel

@juan131
Copy link
Collaborator

juan131 commented Sep 24, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2018
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 24, 2018
@desaintmartin
Copy link
Collaborator Author

desaintmartin commented Sep 24, 2018

I was just doing it! Thanks!

@juan131
Copy link
Collaborator

juan131 commented Sep 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 480a7f8 into helm:master Sep 24, 2018
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@desaintmartin desaintmartin deleted the redis-toleration branch November 21, 2019 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants