This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Fixed syntax error in prometheus-adapter #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mateiidavid
changed the title
|
I don't have approve rights, but this looks good to me :) |
mattfarina
added
the
Contribution Allowed
|
@Matei207 there's another occurrence in that maybe could be fixed too? |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
davidkarlsen
suggested changes
Sep 6, 2018
stable/prometheus-adapter/templates/custom-metrics-apiserver-service.yaml
Show resolved
Hide resolved
ey-bot
removed
the
Contribution Allowed
|
Hi @davidkarlsen, sorry for the long wait, I was on holiday. Thanks for pointing it out to me, I've updated the PR to also include the fix in Let me know if there is anything else that's missing! |
mateiidavid
force-pushed
the
bugfix/prometheus-adapter-syntax-error
branch
from
97e1bd9 to
d7585a3
Compare
ey-bot
added
the
Contribution Allowed
mateiidavid
force-pushed
the
bugfix/prometheus-adapter-syntax-error
branch
from
d7585a3 to
f7b0b48
Compare
ey-bot
removed
the
Contribution Allowed
…label to labels) Signed-off-by: Matei David <[email protected]>
mateiidavid
force-pushed
the
bugfix/prometheus-adapter-syntax-error
branch
from
f7b0b48 to
7d3356f
Compare
ey-bot
added
the
Contribution Allowed
davidkarlsen
approved these changes
Sep 19, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, Matei207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
legal90
added a commit
to volvo-cars/helm-charts
that referenced
this pull request
Sep 21, 2018
* superset-annotations: (27 commits) [stable/superset] Bump version to 0.1.3 [stable/superset] Add service annotations support [stable/drupal] Fix chart not being upgradable (helm#7825) [stable/parse] Fix chart not being upgradable (helm#7824) [stable/jasperreports] Fix chart not being upgradable (helm#7818) [stable/osclass] Fix chart not being upgradable (helm#7817) [stable/phpbb] Fix chart not being upgradable (helm#7820) [stable/ghost] Fix chart not being upgradable (helm#7814) [stable/suitecrm] Fix chart not being upgradable (helm#7816) [stable/phpmyadmin] Fix chart not being upgradable (helm#7830) [stable/magento] Release 2.0.6 (helm#7810) [stable/wordpress] Fix chart not being upgradable (helm#7831) [stable/mongodb] Use .Values.existingSecret for standalone deployments (helm#7839) [incubator/kafka]: add reassignPartitions to topic configuration (helm#7623) Changed syntax error in custom-metrics-apiserver-service and secret (label to labels) (helm#7295) [stable/spinnaker] Changing email of dwardu89 (helm#7838) fix: mongo init issues (helm#7772) [stable/mattemost-team-edition] Add initial charts for Mattermost Team Edition (helm#5987) Fixed TLS Ingress, updated mongo dep requirements and app to latest version (helm#7636) Adding dwardu89 to owners and chart maintainers of stable/spinnaker (helm#7751) ...
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
…label to labels) (helm#7295) Signed-off-by: Matei David <[email protected]> Signed-off-by: jenkin-x <[email protected]>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…label to labels) (helm#7295) Signed-off-by: Matei David <[email protected]> Signed-off-by: Jakob Niggel <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…label to labels) (helm#7295) Signed-off-by: Matei David <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes syntax error in
prometheus-adapterchartWhich issue this PR fixes : fixes #7293