[stable/mongodb-replicaset]: Updated environment variables in on-star…#4393
[stable/mongodb-replicaset]: Updated environment variables in on-star…#4393scottcrespo wants to merge 3 commits intohelm:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: scottcrespo Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @scottcrespo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
… script to access the correct values. Updated README with instructions on how to properly enable authentication.
k8s-ci-robot
added
size/XXL
|
Updated documentation and fixed environment variables in startup script |
|
Can you please review? |
k8s-ci-robot
added
size/XXL
k8s-ci-robot
added
size/S
| admin_user="$ADMIN_USER" | ||
| admin_password="$ADMIN_PASSWORD" | ||
| admin_user="$MONGO_INITDB_ROOT_USERNAME" | ||
| admin_password="$MONGO_INITDB_ROOT_PASSWORD" |
There was a problem hiding this comment.
Why did you change these? This doesn't make sense.
There was a problem hiding this comment.
You're right. I dug into things a bit more and it really doesn't make sense.
I grabbed this solution from the thread in #2976 and it "just works." But, it shouldn't be accepted on that basis.
I think the rationale comes from the fact the underlying mongo docker image looks for MONGO_INITDB_ROOT_UESRNAME and MONGO_INITDB_ROOT_PASSWORD to create an initial admin user, and I think this issue might be pertinent to the problem reported in #2976
Perhaps mongodb-replicaset on-start.sh is clashing with underlying docker container's entrypoint script
That's the best I have to offer so far. Do you have an ideas of the root cause of the problem? Specifically, I'm trying to resolve the issue of the user not being properly created (or I can't log in with the user) when supplying a pre-existing secret to values.yaml.
It's bee some time since I first encountered the problem, so I need to go back and verify I can reproduce the issue. Please let me know your thoughts!
There was a problem hiding this comment.
I'm currently also looking into this. I'm working on a fix that moves all chart-related options out of the config file and passes them to mongod. This will make configuration much easier and the user won't have to make changes in multiple places.
There was a problem hiding this comment.
Awesome! Then I think I should close this PR. Sound good to you?
I think we both agree this is not the right solution, and it sounds like you're coming up with something much more comprehensive.
|
/assign |
|
Thanks @scottcrespo |
3 participants
…t script to access the correct values. Updated README with instructions on how to properly enable authentication.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: