Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@caulagi
Copy link
Contributor

@caulagi caulagi commented Feb 22, 2018

The instructions provided by NOTES.txt doesn't work because the label on the deployment doesn't match the label used in NOTES.txt.

$ helm status eyewitness-lamb
LAST DEPLOYED: Thu Feb 22 15:23:44 2018
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/Service
NAME      TYPE       CLUSTER-IP     EXTERNAL-IP  PORT(S)   AGE
heapster  ClusterIP  100.64.31.201  <none>       8082/TCP  1h

==> v1beta1/Deployment
NAME                      DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
eyewitness-lamb-heapster  1        1        1           1          1h

==> v1/Pod(related)
NAME                                       READY  STATUS   RESTARTS  AGE
eyewitness-lamb-heapster-66f796c55b-q86kh  2/2    Running  0         1h


NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace default -l "app=heapster" -o jsonpath="{.items[0].metadata.name}")
  kubectl --namespace default port-forward $POD_NAME 8082

And the output of the pod itself from kubectl -

$ kubectl describe pod eyewitness-lamb-heapster-66f796c55b-q86kh

Name:           eyewitness-lamb-heapster-66f796c55b-q86kh
Namespace:      default
Node:           ip-10-255-63-126.eu-central-1.compute.internal/10.255.63.126
Start Time:     Thu, 22 Feb 2018 15:23:45 +0100
Labels:         app=eyewitness-lamb-heapster
                pod-template-hash=2293527116
Annotations:    kubernetes.io/created-by={"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"ReplicaSet","namespace":"default","name":"eyewitness-lamb-heapster-66f796c55b","uid":"fd44fde0-17db-11e8-a...
Status:         Running
IP:             100.102.116.133
Created By:     ReplicaSet/eyewitness-lamb-heapster-66f796c55b
Controlled By:  ReplicaSet/eyewitness-lamb-heapster-66f796c55b

So NOTES.txt looks for the label app=heapster but the pod has the label app=eyewitness-lamb-heapster. This was changed in #2144.

I matched the NOTES.txt to match the label in deployment.yaml (though we could do it the other way round also).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2018
@caulagi
Copy link
Contributor Author

caulagi commented Feb 22, 2018

/assign @mgoodness

@unguiculus
Copy link
Member

Thanks. Please bump the chart version.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2018
@caulagi
Copy link
Contributor Author

caulagi commented Feb 24, 2018

@unguiculus Fixed.

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caulagi, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit c952059 into helm:master Feb 24, 2018
@caulagi caulagi deleted the patch-1 branch February 24, 2018 18:01
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* Match the label in deployment yaml

* Bump version
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* Match the label in deployment yaml

* Bump version

Signed-off-by: voron <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants