-
Notifications
You must be signed in to change notification settings - Fork 16.5k
[stable/mongodb-replicaset] Various improvements #3728
Conversation
|
@foxish Could you push the new install image, please? |
|
I'm not sure if it is the best place to point this out, probably out of the scope of the PR. But wouldn't be a good idea to use the This would allow to join forces with the It supports replication: |
|
@qcho Switching to the Bitnami image is definitely out of scope for this PR. It would probably require quite some refactoring. And to be honest, I don't see why we should move away from the official Mongo image. |
551b4a0 to
1f1255c
Compare
* Add OWNERS file * Better script formatting and quoting * Change directory of config file to the location expected by the scripts in the Docker image * Run MongoDB as non-root user
1f1255c to
70c35c5
Compare
|
/lgtm |
Will try again in a while. Unable to build the image atm. |
|
@foxish @unguiculus seeing the error: |
34b3fa4 to
583011c
Compare
cb01114 to
67d81f8
Compare
67d81f8 to
65b08f7
Compare
|
Pushed the new image. This should be good to go. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxish, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
8e0cd9c to
c005fb6
Compare
* [stable/mongodb-replicaset] Various improvements * Add OWNERS file * Better script formatting and quoting * Change directory of config file to the location expected by the scripts in the Docker image * Run MongoDB as non-root user * Update install image in values.yaml and readme * Update versions in readme * Remove invalid 'runAsGroup' * Fix auth * Move on-start.sh out of Docker image * Wait for replicas to reach desired state * Rename CA secret * Bump version to 3.0.0 * Apply fix for readonly configmap mounts * Update image config * Improve PDB configuration * Update install image
* [stable/mongodb-replicaset] Various improvements * Add OWNERS file * Better script formatting and quoting * Change directory of config file to the location expected by the scripts in the Docker image * Run MongoDB as non-root user * Update install image in values.yaml and readme * Update versions in readme * Remove invalid 'runAsGroup' * Fix auth * Move on-start.sh out of Docker image * Wait for replicas to reach desired state * Rename CA secret * Bump version to 3.0.0 * Apply fix for readonly configmap mounts * Update image config * Improve PDB configuration * Update install image Signed-off-by: voron <av@arilot.com>
by the scripts in the Docker image
mongodoption to cli args in order to make configuration easieron-start.shout of install Docker image into configmap in order to not rely on new images to be pushed when changes are made