Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@unguiculus
Copy link
Member

@unguiculus unguiculus commented Feb 14, 2018

  • Add OWNERS file
  • Better script formatting and quoting
  • Change directory of config file to the location expected
    by the scripts in the Docker image
  • Run MongoDB as non-root user
  • Move all chart-related mongod option to cli args in order to make configuration easier
  • Move on-start.sh out of install Docker image into configmap in order to not rely on new images to be pushed when changes are made
  • Improve MongoDB initialization waiting for replicas to reach the desired state
  • Fix issues with read-only configmaps with Kubernetes 1.9.4
  • Improve pod disruption budget configuration

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2018
@unguiculus unguiculus requested a review from foxish February 14, 2018 11:21
@unguiculus
Copy link
Member Author

@foxish Could you push the new install image, please?

@qcho
Copy link
Contributor

qcho commented Feb 16, 2018

I'm not sure if it is the best place to point this out, probably out of the scope of the PR. But wouldn't be a good idea to use the bitnami image as the stable/mongodb chart does?

This would allow to join forces with the stable/mongodb owners, be at the last stable mongodb version (today replicaset is at appversion: 3.4) with ease.

It supports replication:
https://github.com/bitnami/bitnami-docker-mongodb#setting-up-a-replication

@unguiculus
Copy link
Member Author

@qcho Switching to the Bitnami image is definitely out of scope for this PR. It would probably require quite some refactoring. And to be honest, I don't see why we should move away from the official Mongo image.

@unguiculus unguiculus changed the title [stable/mongodb-replicaset] Add OWNERS file and various improvements [stable/mongodb-replicaset] Various improvements Feb 20, 2018
* Add OWNERS file
* Better script formatting and quoting
* Change directory of config file to the location expected
  by the scripts in the Docker image
* Run MongoDB as non-root user
@foxish
Copy link
Member

foxish commented Mar 13, 2018

/lgtm
Pushing the image now.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2018
@foxish
Copy link
Member

foxish commented Mar 13, 2018

docker build -t k8s.gcr.io/mongodb-install:0.6 .
Sending build context to Docker daemon 11.78 kB
Step 1 : FROM alpine:3.4
 ---> c7fc7faf8c28
Step 2 : MAINTAINER Anirudh Ramanathan <foxish@google.com>
 ---> Using cache
 ---> 12a8760ffe0d
Step 3 : RUN apk update && apk add bash openssl && wget -qO /peer-finder http://storage.googleapis.com/kubernetes-release/pets/peer-finder
 ---> Running in 84ca977cc024
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/main/x86_64/APKINDEX.tar.gz
ERROR: http://dl-cdn.alpinelinux.org/alpine/v3.4/main: temporary error (try again later)
WARNING: Ignoring APKINDEX.167438ca.tar.gz: No such file or directory
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/community/x86_64/APKINDEX.tar.gz
ERROR: http://dl-cdn.alpinelinux.org/alpine/v3.4/community: temporary error (try again later)
WARNING: Ignoring APKINDEX.a2e6dac0.tar.gz: No such file or directory
2 errors; 11 distinct packages available
The command '/bin/sh -c apk update && apk add bash openssl && wget -qO /peer-finder http://storage.googleapis.com/kubernetes-release/pets/peer-finder' returned a non-zero code: 2

Will try again in a while. Unable to build the image atm.

@mattfarina
Copy link
Contributor

@foxish @unguiculus seeing the error:

Error: error validating "": error validating data: found invalid field runAsGroup for v1.SecurityContext

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2018
@foxish
Copy link
Member

foxish commented Apr 2, 2018

Pushed the new image. This should be good to go.
Thanks @mattfarina for catching that.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxish, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2018
@unguiculus unguiculus added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8e38c4f into helm:master Apr 3, 2018
@unguiculus unguiculus deleted the feature/mongo branch April 3, 2018 17:39
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* [stable/mongodb-replicaset] Various improvements

* Add OWNERS file
* Better script formatting and quoting
* Change directory of config file to the location expected
  by the scripts in the Docker image
* Run MongoDB as non-root user

* Update install image in values.yaml and readme

* Update versions in readme

* Remove invalid 'runAsGroup'

* Fix auth

* Move on-start.sh out of Docker image

* Wait for replicas to reach desired state

* Rename CA secret

* Bump version to 3.0.0

* Apply fix for readonly configmap mounts

* Update image config

* Improve PDB configuration

* Update install image
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* [stable/mongodb-replicaset] Various improvements

* Add OWNERS file
* Better script formatting and quoting
* Change directory of config file to the location expected
  by the scripts in the Docker image
* Run MongoDB as non-root user

* Update install image in values.yaml and readme

* Update versions in readme

* Remove invalid 'runAsGroup'

* Fix auth

* Move on-start.sh out of Docker image

* Wait for replicas to reach desired state

* Rename CA secret

* Bump version to 3.0.0

* Apply fix for readonly configmap mounts

* Update image config

* Improve PDB configuration

* Update install image

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants