Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] deprecate chart #23738

Merged
merged 2 commits into from
Sep 9, 2020
Merged

[stable/prometheus-operator] deprecate chart #23738

merged 2 commits into from
Sep 9, 2020

Conversation

scottrigby
Copy link
Member

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

This chart has successfully moved 🎉

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
    - [ ] Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020
unguiculus
unguiculus previously requested changes Sep 9, 2020
View reviewed changes
stable/prometheus-operator/Chart.yaml Outdated Show resolved Hide resolved
@scottrigby @unguiculus
Update stable/prometheus-operator/Chart.yaml
0434e49 
Signed-off-by: Scott Rigby <[email protected]>

Co-authored-by: Reinhard Nägele <[email protected]>
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scottrigby, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@scottrigby scottrigby mentioned this pull request Sep 9, 2020
Closed
4 tasks
@scottrigby
Copy link
Member Author

Looks like test infra had issues earlier, and this has been stuck for a few hours

@scottrigby
Copy link
Member Author

/test all

@scottrigby
Copy link
Member Author

Not sure we even need to test this, as it's just a deprecation. But let's see if it does it on it's own now.

@scottrigby scottrigby mentioned this pull request Sep 9, 2020
Closed
@scottrigby
Copy link
Member Author

It's stuck again. Merging

@scottrigby scottrigby merged commit d0d852d into helm:master Sep 9, 2020
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bismarck bismarck Awaiting requested review from bismarck

@vsliouniaev vsliouniaev Awaiting requested review from vsliouniaev

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottrigby @unguiculus @k8s-ci-robot @helm-bot