[stable/nginx-ingress] Add an ability to provide custom nginx template and dhparam

[s4nch3z]

No description provided.

[k8s-ci-robot]

Hi @s4nch3z. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[erickt]

@mgoodness: have you had a chance to look at this? Due to the breaking change in 1.8 that I go into detail in kubernetes/ingress-nginx#1622, it would be really handy to override the nginx template in order to allow ELBs to offload TLS, at least until there's a proper solution from the ingress-nginx folks.

[unguiculus]

For consistency, you may want to create helper templates for the resources names.

[unguiculus]

And sorry for the delay. I'm picking this up now.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s4nch3z
We suggest the following additional approver: mgoodness

Assign the PR to them by writing /assign @mgoodness in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[unguiculus]

I figured custom template have already made it in. I'm closing this now. Again sorry for the delay. Please open a new PR for dhparam if you like. Thanks.