-
Notifications
You must be signed in to change notification settings - Fork 16.5k
[stable/ghost] #1785 namespace defined templates with chart name #2147
[stable/ghost] #1785 namespace defined templates with chart name #2147
Conversation
|
Hi @kevinschumacher. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign |
|
@kevinschumacher another one needs rebase. |
| @@ -1,7 +1,8 @@ | |||
| name: ghost | |||
| version: 1.0.2 | |||
| version: 2.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a minor version update and not major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ignore this comment as we agreed that major version update is the right thing
|
@kevinschumacher this still needs re-basing |
|
/lgtm |
#1785