Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-ops-view] #1785 namespace defined templates with chart name #2134

Merged
dhilipkumars merged 1 commit into from
Sep 19, 2017
Merged

[stable/kube-ops-view] #1785 namespace defined templates with chart name #2134

dhilipkumars merged 1 commit into from
Sep 19, 2017

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Sep 17, 2017

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2017
@kevinschumacher kevinschumacher mentioned this pull request Sep 17, 2017
Closed
@dhilipkumars dhilipkumars removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 18, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Sep 18, 2017

/assign
/ok-to-test

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Sep 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2017
@dhilipkumars dhilipkumars merged commit 007bd2d into helm:master Sep 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinschumacher @k8s-ci-robot @dhilipkumars