[incubator/gitea] Initial commit of chart. #2083
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @jpds. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
size/XL
migrations to happen on first start.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
unguiculus
left a comment
unguiculus
left a comment
There was a problem hiding this comment.
Note that we've started namespacing templates (see #1785). You should apply this to your chart (can be done in another PR) in order for this chart to move to stable.
| apiVersion: v1 | ||
| metadata: | ||
| labels: | ||
| app: {{ template "fullname" . }}-config |
There was a problem hiding this comment.
app label should be {{ template "name" . }} on all resources.
| component: {{ default "gitea" .Values.service.nameOverride }} | ||
| heritage: {{ .Release.Service }} | ||
| release: {{ .Release.Name }} | ||
| name: {{ template "fullname" . }}-config |
There was a problem hiding this comment.
All other resources are named {{ template "fullname" . }}. So should be the configmap.
| labels: | ||
| app: {{ template "fullname" . }}-config | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| component: {{ default "gitea" .Values.service.nameOverride }} |
There was a problem hiding this comment.
I don't see why a component label on the configmap would make sense. I'd suggest you remove it.
|
Marking this a stale. Please update within one week. |
|
Closing as stale. |
4 participants
No description provided.