Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minio] Fix helm 3 install error #19245

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

daixiang0
Copy link
Collaborator

Signed-off-by: Xiang Dai [email protected]

What this PR does / why we need it:

Support helm 3 install.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Xiang Dai <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2019
@daixiang0
Copy link
Collaborator Author

ping @wlan0 @nitisht

@davidkarlsen
Copy link
Member

/lgtm

@davidkarlsen
Copy link
Member

/assign

@nitisht
Copy link
Contributor

nitisht commented Dec 4, 2019

/ok-to-test

@nitisht
Copy link
Contributor

nitisht commented Dec 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daixiang0, davidkarlsen, nitisht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 60e82d8 into helm:master Dec 5, 2019
@daixiang0 daixiang0 deleted the minio branch December 5, 2019 01:52
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
WyriHaximus pushed a commit to WyriHaximus-labs/charts that referenced this pull request Dec 14, 2019
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Artur <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/minio] KubeVersion.GitVersion is Deprecated
5 participants