Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/gogs] #1785 namespace defined templates with chart name #1834

Merged
dhilipkumars merged 5 commits into from
Sep 14, 2017
Merged

[incubator/gogs] #1785 namespace defined templates with chart name #1834

dhilipkumars merged 5 commits into from
Sep 14, 2017

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Aug 23, 2017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 23, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinschumacher kevinschumacher mentioned this pull request Aug 23, 2017
Closed
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 24, 2017

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 24, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 26, 2017

@kevinschumacher please fix the ci error

I0824 04:28:00.532] [ERROR] templates/: parse error in "gogs/templates/_helpers.tpl": template: gogs/templates/_helpers.tpl:2: template: multiple definition of template "gogs.fullname"

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2017
@kevinschumacher
Copy link
Contributor Author

kevinschumacher commented Sep 4, 2017

/retest

Sorry about delay on this. Busy at work, then busy on vacation!

@kevinschumacher
Copy link
Contributor Author

kevinschumacher commented Sep 7, 2017

conflict resolved

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Sep 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Sep 14, 2017

/retest

@dhilipkumars dhilipkumars merged commit ec69119 into helm:master Sep 14, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Sep 14, 2017

@kevinschumacher Apologies for the delay in responding.

s4nch3z pushed a commit to s4nch3z/charts that referenced this pull request Sep 18, 2017
@kevinschumacher @s4nch3z
[incubator/gogs] helm#1785 namespace defined templates with chart name (
5615466 
helm#1834)

* [incubator/gogs] helm#1785 namespace defined templates with chart name

* Revert "[incubator/gogs] helm#1785 namespace defined templates with chart name"

This reverts commit a5a8a86.

* [incubator/gogs] helm#1785 namespace defined templates with chart name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinschumacher @k8s-ci-robot @dhilipkumars