Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/redis] namespace the template helpers with chart name ({{ define "fullname" }} --> {{ define "redis.fullname" }} #1758

Merged
dhilipkumars merged 1 commit into from
Aug 17, 2017
Merged

[stable/redis] namespace the template helpers with chart name ({{ define "fullname" }} --> {{ define "redis.fullname" }} #1758

dhilipkumars merged 1 commit into from
Aug 17, 2017

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Aug 17, 2017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinschumacher kevinschumacher changed the title [stable/redis] namespace the template helpers with chart name ({{ template "fullname" }} --> {{ template "redis.fullname" }} [stable/redis] namespace the template helpers with chart name ( {{ template "fullname" }} --> {{ template "redis.fullname" }} ) Aug 17, 2017
@kevinschumacher kevinschumacher changed the title [stable/redis] namespace the template helpers with chart name ( {{ template "fullname" }} --> {{ template "redis.fullname" }} ) [stable/redis] namespace the template helpers with chart name ({{ define "fullname" }} --> {{ define "redis.fullname" }} Aug 17, 2017
@kevinschumacher
Copy link
Contributor Author

kevinschumacher commented Aug 17, 2017

FYI I would be happy to do this for other charts as well. Please let me know if that's something that I should take on.

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 17, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 17, 2017

/assign

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 17, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Aug 17, 2017

@kevinschumacher Thanks for the PR.

@dhilipkumars dhilipkumars merged commit b91b71b into helm:master Aug 17, 2017
@kevinschumacher kevinschumacher mentioned this pull request Aug 20, 2017
Closed
@kevinschumacher kevinschumacher deleted the bug/namespace-template-helpers branch August 20, 2017 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinschumacher @k8s-ci-robot @dhilipkumars