Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/dex] Add support to always display login screen #16806

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[stable/dex] Add support to always display login screen #16806

merged 1 commit into from
Sep 4, 2019

Conversation

maxlegault
Copy link
Contributor

What this PR does / why we need it:

The current indentation of the OAuth2 configuration block doesn't allow
for extra properties to be added. This allows to enable the new
configuration that will always display the login screen, even though
only one connector is defined.

The default value (disabled) is also added to the values file for
documentation.

See also: https://github.com/dexidp/dex/releases/tag/v2.18.0
See also: dexidp/dex#1505

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@maxlegault
Add support to always display login screen
28ce32e 
The current indentation of the OAuth2 configuration block doesn't allow
for extra properties to be added. This allows to enable the new
configuration that will always display the login screen, even though
only one connector is defined.

The default value (disabled) is also added to the values file for
documentation.

See also: https://github.com/dexidp/dex/releases/tag/v2.18.0
See also: dexidp/dex#1505

Signed-off-by: Maxime Legault-Venne <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bernyfox. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2019
@vi7
Copy link
Collaborator

vi7 commented Sep 4, 2019

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bernyfox, vi7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@vi7
Copy link
Collaborator

vi7 commented Sep 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 97076f8 into helm:master Sep 4, 2019
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@maxlegault @kengou
Add support to always display login screen (helm#16806)
50f5a45 
The current indentation of the OAuth2 configuration block doesn't allow
for extra properties to be added. This allows to enable the new
configuration that will always display the login screen, even though
only one connector is defined.

The default value (disabled) is also added to the values file for
documentation.

See also: https://github.com/dexidp/dex/releases/tag/v2.18.0
See also: dexidp/dex#1505

Signed-off-by: Maxime Legault-Venne <[email protected]>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@maxlegault
Add support to always display login screen (helm#16806)
d5b5584 
The current indentation of the OAuth2 configuration block doesn't allow
for extra properties to be added. This allows to enable the new
configuration that will always display the login screen, even though
only one connector is defined.

The default value (disabled) is also added to the values file for
documentation.

See also: https://github.com/dexidp/dex/releases/tag/v2.18.0
See also: dexidp/dex#1505

Signed-off-by: Maxime Legault-Venne <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vi7 vi7 vi7 approved these changes

@desaintmartin desaintmartin Awaiting requested review from desaintmartin

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxlegault @k8s-ci-robot @vi7 @helm-bot