Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/faktory] Added chart for Contribsys/Faktory #13974

Closed
wants to merge 1 commit into from

Conversation

dm3ch
Copy link

@dm3ch dm3ch commented May 19, 2019

Signed-off-by: Dmitry Chepurovskiy [email protected]

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dm3Ch
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: davidkarlsen

If they are not already assigned, you can assign the PR to them by writing /assign @davidkarlsen in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dm3ch. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2019
@dm3ch dm3ch changed the title Added chart for Contribsys/Faktory [incubator/faktory] Added chart for Contribsys/Faktory May 19, 2019
@dm3ch
Copy link
Author

dm3ch commented May 19, 2019

/assign @davidkarlsen

Signed-off-by: Dmitry Chepurovskiy <[email protected]>
@maorfr
Copy link
Member

maorfr commented May 21, 2019

hey @dm3ch

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

@dm3ch
Copy link
Author

dm3ch commented May 28, 2019

@maorfr Hello!
To be honest I didn't knew about helm hub before you wrote that message.

I'm going to read how to create my own chart repo and how to add it to helm hub.

@stale
Copy link

stale bot commented Jun 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2019
@stale
Copy link

stale bot commented Jul 11, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jul 11, 2019
@jbielick jbielick mentioned this pull request Dec 9, 2019
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants