Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Concourse postgres conditional dependency #1390

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Concourse postgres conditional dependency #1390

merged 3 commits into from
Jul 6, 2017

Conversation

william-tran
Copy link
Collaborator

@william-tran william-tran commented Jun 28, 2017 •
edited
Loading

Fixes #1056

Will Tran added 2 commits May 9, 2017 16:00
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 28, 2017
@william-tran
Copy link
Collaborator Author

I've signed the CLA and registered

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 28, 2017
@viglesiasce
Copy link
Contributor

/ok-to-test

@viglesiasce viglesiasce merged commit 40a297e into helm:master Jul 6, 2017
gmile
gmile reviewed Jul 7, 2017
View reviewed changes
stable/concourse/README.md
## If bringing your own PostgreSQL, the full uri to use
## e.g. postgres://concourse:[email protected]:5432/concourse?sslmode=require
##
uri: postgres://concourse:[email protected]:5432/concourse?sslmode=require
Copy link
Contributor

@gmile gmile Jul 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to specify a uri with credentials that are not known upfront? E.g. when existing postgres installation pulls password from a secret object in cluster

lachie83 added a commit to lachie83/charts that referenced this pull request Jul 10, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
d08422a 
* upstream/master: (67 commits)
  Fix json whitespace (helm#1458)
  Use consistent whitespace in template placeholders (helm#1437)
  [stable/selenium] Make hub readiness probe timeout configurable (helm#1391)
  [stable/kube2iam]: add rbac support (helm#1286)
  [stable/traefik] Allow enabling traefik access logs (helm#1302)
  Add Stash chart (helm#1420)
  Add Gearman G2 chart (helm#1421)
  add option to include tolerations to daemonset (helm#1364)
  Moved Artifactory to stable and updated version to 5.3.2 (helm#1314)
  Concourse postgres conditional dependency (helm#1390)
  Typo in helm install command for dask-distributed (helm#1413)
  [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417)
  fixed cassandra chart's persistence bug (helm#1245)
  Prometheus: modify config to support k8s 1.6 by default (helm#1080)
  Add rocket.chat (helm#752)
  Fix influxdb deployment (helm#1424)
  feat(stable/etcd-operator): add support for supplying additional command args (helm#1418)
  add configurable service annotations helm#1234 (helm#1244)
  [stable/prometheus] extra environment variable for alert manager (helm#1237)
  [stable/heapster] Default service name to Heapster (helm#1266)
  ...
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
Concourse postgres conditional dependency (helm#1390)
3277663 
* Conditional dependency on postgres.

Fixes helm#1056

* Update readme for conditional PostgreSQL dependency

Also add a section on restarting workers

* Update Chart.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gmile gmile gmile left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@william-tran @k8s-ci-robot @viglesiasce @gmile