Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/aws-cluster-autoscaler] Update docker container to v0.5.4 #1101

Merged

Conversation

mikesplain
Copy link
Contributor

Since kubernetes v1.6.* has been out for awhile, we should probably bump this chart by default to give new users a better experience. Aws-cluster-autoscaler has a 1-to-1 dependency on the version of kubernetes. We should really encourage users to set their own image tag on this chart. I added a note to #684 to mention this as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mikesplain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2017
@unguiculus
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 22, 2017
@mgoodness mgoodness self-assigned this May 25, 2017
@mgoodness
Copy link
Contributor

Along with documenting the K8s version dependency, I wonder if we could use Helm's Capabilities.KubeVersion scope (documented here).

@prydonius
Copy link
Member

We are working on figuring out how we tell users what kubernetes versions a chart supports (cc @foxish). In the meantime, I think we can merge this.

@prydonius prydonius added lgtm Indicates that a PR is ready to be merged. UX reviewed and removed changes needed stale labels Jun 20, 2017
@prydonius prydonius merged commit 0fddb59 into helm:master Jun 20, 2017
@mikesplain mikesplain deleted the stable/aws-cluster-autoscaler-v0.5.4 branch June 20, 2017 20:27
lachie83 added a commit to lachie83/charts that referenced this pull request Jul 10, 2017
* upstream/master: (52 commits)
  [redmine] add ingress (helm#1336)
  [stable/jenkins] Use imageTag as version in config map (helm#1333)
  - Bump to latest Minio release (helm#1304)
  Update k8s-dashboard note when ingress is enabled (helm#1339)
  Update etcd-operator to latest release (helm#1248)
  [stable/nginx-ingress] Add hostNetwork option (helm#1250)
  Update the CONTRIBUTING.md to reflect the new #helm-users and #helm-dev channels (helm#1315)
  Submit stable Voyager chart (helm#954)
  [datadog] Add optional kube-state-metrics pod (helm#1011)
  [stable/prestashop] Release 0.4.10 (helm#1267)
  [stable/wordpress] Release 0.6.5 (helm#1270)
  [stable/phabricator] Release 0.4.9 (helm#1281)
  [stable/drupal] Release 0.6.2 (helm#1268)
  Bump aws-cluster-autoscaler to latest. (helm#1101)
  Use memcached modern recommended options instead (helm#1221)
  Update NOTES.txt (helm#1316)
  Rename MARIADB_PORT env var to MARIADB_PORT_NUMBER (helm#1210)
  Rename POSTGRESQL_PORT env var to POSTGRESQL_PORT_NUMBER (helm#1189)
  Kubernetes Dashboard Chart (helm#808)
  Add best practices to requirements (helm#1305)
  ...
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants