Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Default config options not applied in templates #1461

Closed
patricklucas opened this issue Jul 10, 2017 · 4 comments · Fixed by #3292
Closed

[stable/grafana] Default config options not applied in templates #1461

patricklucas opened this issue Jul 10, 2017 · 4 comments · Fixed by #3292

Comments

@patricklucas
Copy link
Contributor

In the grafana chart, two entries in values.yaml, server.setDatasource.image and server.setDatasource.restartPolicy are documented with defaults, but these defaults are not actually applied in the templates causing confusing errors like:

Error: failed to create resource: Job.batch "grafana-grafana-set-datasource" is invalid: [spec.template.spec.containers[0].image: Required value, spec.template.spec.restartPolicy: Unsupported value: "Always": supported values: OnFailure, Never]
@patricklucas
Copy link
Contributor Author

I believe this also applies to the templated JSON in the args to curl in job.yaml.

@fhemberger
Copy link
Contributor

Related: #1458

@patricklucas
Copy link
Contributor Author

Hmm is this related? I ran into the other issue as well, but in this case there is a documented default (that is commented out) in values.yaml but in the template it is referenced with {{ Values.some.var }} instead of e.g. {{ default "some default value" Values.some.var }}.

@jeff-knurek jeff-knurek mentioned this issue Aug 22, 2017
Closed
@fiunchinho
Copy link
Contributor

Which image should be used for server.setDatasource.image ?

@jwhitcraft jwhitcraft mentioned this issue Jan 10, 2018
Merged
jwhitcraft pushed a commit to jwhitcraft/charts that referenced this issue Jan 10, 2018
[stable/grafana] fix grafana default config options
a7447e9 
Set the defaults as outlined by the values.yaml file.

fixes helm#1461
k8s-ci-robot pushed a commit that referenced this issue Jan 16, 2018
@k8s-ci-robot
[stable/grafana] fix grafana default config options (#3292)
c2f9a3a 
* [stable/grafana] fix grafana default config options

Set the defaults as outlined by the values.yaml file.

fixes #1461

* Bump Chart Version

* Move default values into values.yaml instead of job.yaml

* Forgot to uncomment datasource
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stable/grafana] fix grafana default config options jwhitcraft/charts
3 participants
@patricklucas @fhemberger @fiunchinho