Update kind example #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use kind release from GitHub instead of 'go get sigs.k8s.io/kind' * Run ct container with '--network host' to avoid patching kubeconfig * Create multi-node cluster with one master and three worker nodes so pods with anti-affinity can be tested * Improve wait logic to cater for multiple nodes * Add log statements * Remote unnecessary 'k8s' remote to avoid confusion * Extract function for 'docker exec' calls Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus
force-pushed
the
update-kind
branch
from
329d0ba to
4c78045
Compare
|
/lgtm |
cpanato
approved these changes
Jan 24, 2019
mattfarina
approved these changes
Jan 24, 2019
There was a problem hiding this comment.
This lgtm. But, since I didn't test it via CircleCI I'll leave it to @unguiculus to merge
|
I did test it pretty extensively. 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so pods with anti-affinity can be tested
Signed-off-by: Reinhard Nägele [email protected]