Fix regression in changed chart detection

[unguiculus]

Fixes #84

[Flydiverny]

Seems good to me 👍

Tested:

• changing something in templates/service.yaml -> lint detects and asks for version bump
• changing maintainer in Chart.yaml -> lint detects and asks for version bump
• changing templates/service.yaml & version in Chart.yaml -> lint detects and passes

[Flydiverny]

Also tested setting chart-dirs as . (root), here it doesn't seem to detect changes with this revert. Does detect with 2.0.1 tho.

------------------------------------------------------------------------------------------------------------------------
 Configuration
------------------------------------------------------------------------------------------------------------------------
Remote: origin
TargetBranch: master
BuildId:
LintConf: lintconf.yaml
ChartYamlSchema: chart_schema.yaml
ValidateMaintainers: true
ValidateChartSchema: true
ValidateYaml: true
CheckVersionIncrement: true
ProcessAllCharts: false
Charts: []
ChartRepos: []
ChartDirs: [.]
ExcludedCharts: []
HelmExtraArgs: --timeout 800
HelmRepoExtraArgs: []
Debug: true
Namespace:
ReleaseLabel:
------------------------------------------------------------------------------------------------------------------------
>>> git merge-base origin/master HEAD
>>> git diff --find-renames --name-only b00fdb7fcc0dbd813517b6523cdecb0a6c01d68b -- .
All charts linted successfully
------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------

λ git diff --find-renames --name-only b00fdb7fcc0dbd813517b6523cdecb0a6c01d68b -- .
ct.yaml
notifications/.helmignore
notifications/Chart.yaml
notifications/templates/NOTES.txt
notifications/templates/_helpers.tpl
notifications/templates/deployment.yaml
notifications/templates/job.yaml
notifications/templates/pdb.yaml
notifications/templates/service.yaml
notifications/values.yaml

[Flydiverny]

		dir := path.Join(pathElements[0], pathElements[1])
		rootDir := filepath.Dir(file)
		// Only add if not already in list and double-check if it is a chart directory
		if !util.StringSliceContains(changedChartDirs, dir) && t.chartUtils.IsChartDir(dir) {
			changedChartDirs = append(changedChartDirs, dir)
		} else if !util.StringSliceContains(changedChartDirs, rootDir) && t.chartUtils.IsChartDir(rootDir) {
			changedChartDirs = append(changedChartDirs, rootDir)
		}

Works for both cases, even tho its not so pretty 😄

[unguiculus]

I refactored it a little bit. Could you test this again? I just quickly made the tests pass but would like to improve those as well.

[Flydiverny]

Tested a bit again:

λ ~/Code/Go/bin/app lint --debug
Linting charts...
Using config file:  /Users/flydiverny/Code/gleerups/chart-repository/ct.yaml
------------------------------------------------------------------------------------------------------------------------
 Configuration
------------------------------------------------------------------------------------------------------------------------
Remote: origin
TargetBranch: master
BuildId:
LintConf: lintconf.yaml
ChartYamlSchema: chart_schema.yaml
ValidateMaintainers: true
ValidateChartSchema: true
ValidateYaml: true
CheckVersionIncrement: true
ProcessAllCharts: false
Charts: []
ChartRepos: []
ChartDirs: [.]
ExcludedCharts: []
HelmExtraArgs: --timeout 800
HelmRepoExtraArgs: []
Debug: true
Namespace:
ReleaseLabel:
------------------------------------------------------------------------------------------------------------------------
>>> git merge-base origin/master HEAD
>>> git diff --find-renames --name-only b00fdb7fcc0dbd813517b6523cdecb0a6c01d68b -- .

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 notifications
 notifications
 notifications
 notifications
 notifications
 notifications
 notifications
------------------------------------------------------------------------------------------------------------------------

Detects changes for both charts in root dir and a "normal" setup with eg stable folder.
However if multiple files are changed for the same chart it will lint it multipletimes.

[Flydiverny]

Need to change order here and check if chartDir is added already. Otherwise we will get multiple entries if there are multiple files changed.

[Flydiverny]

This should work:

		chartDir, err := t.chartUtils.LookupChartDir(cfg.ChartDirs, dir)
		if err == nil {
			if !util.StringSliceContains(changedChartDirs, chartDir) {
				changedChartDirs = append(changedChartDirs, chartDir)
			}
		} else {
			fmt.Printf("Directory '%s' is not chart directory. Skipping...", chartDir)
		}

[unguiculus]

Good catch. Thanks.

[unguiculus]

Fixed as suggested. I figured more elaborate test would no be easy. I'd leave them as is for now.

[Flydiverny]

tested last update works as far as I can tell :)

[scottrigby]

I also tested the same cases in #85 (comment) and it works 👍