Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable printing of container logs #472

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Sep 14, 2022

What this PR does / why we need it:

In some instances ct will stall indefinitely if the log output from the containers is too long. This PR introduces a new configuration option that will disable printing of the container logs.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #471

Special notes for your reviewer:

I am sure this PR isn't ideal, but I am not really sure how to work around my issue. I can say for sure that since using my patched version of ct where log printing is disabled, I have not had ct hang on any job I have ran locally or in a CI job.

@cpanato
Copy link
Member

cpanato commented Sep 16, 2022

@nhudson please rebase

thanks for this PR

@cpanato
Copy link
Member

cpanato commented Sep 16, 2022

can you generate the docs using the doc-gen? will be good as well to fetch the latest code from main

go build -o ct-bin ./ct/main.go

$ ./ct-bin doc-gen
Generating docs...
Done.

@nhudson
Copy link
Contributor Author

nhudson commented Sep 16, 2022

@cpanato thanks! Let me know if there is anything else.

@cpanato cpanato merged commit 5865864 into helm:main Sep 26, 2022
@cpanato
Copy link
Member

cpanato commented Sep 26, 2022

thanks!

@nhudson nhudson deleted the disable-logging branch September 26, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes when printing container logs ct will hang
2 participants