Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests for upgrade flag #446

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

paologallinaharbur
Copy link
Contributor

What this PR does / why we need it:
It fixes:

  • the integration test "change immutable deployment.spec.selector field". Since the selector was missing from the manifest the upgrade tests was always failing causing a false positive. This is because the required fields changed in apps/v1 and selector were not added by Don't create provided namespace #205

The error always showing before the upgrade was:

missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec

It adds:

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks!

@davidkarlsen davidkarlsen merged commit 882d4be into helm:main Jul 22, 2022
@paologallinaharbur
Copy link
Contributor Author

@davidkarlsen do you know if we can have a new release? or maybe you are currently in the process of releasing it already

@davidkarlsen
Copy link
Member

@paologallinaharbur I'll see if I can get to it soon.

@cpanato
Copy link
Member

cpanato commented Jul 26, 2022

@davidkarlsen i will review the repo tomorrow (27/july/2022) and prepare the release, maybe we need to bump a few things

@cpanato
Copy link
Member

cpanato commented Jul 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants