Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signing with cosign to the binaries and images #410

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 14, 2022

What this PR does / why we need it:

  • add signing with cosign to the binaries and images

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@davidkarlsen
Copy link
Member

@cpanato is it possible to use this with workload-identity instead (OIDC) - so we don't have to manage keys?

@davidkarlsen
Copy link
Member

@cpanato is it possible to use this with workload-identity instead (OIDC) - so we don't have to manage keys?

Ah - sorry - you already do :) I just saw the file-reference

@cpanato
Copy link
Member Author

cpanato commented Mar 14, 2022

@cpanato is it possible to use this with workload-identity instead (OIDC) - so we don't have to manage keys?

Ah - sorry - you already do :) I just saw the file-reference

yes, using the OIDC from github :)

@cpanato
Copy link
Member Author

cpanato commented Mar 16, 2022

@davidkarlsen PTAL

@cpanato cpanato merged commit e14c2b2 into helm:main Mar 23, 2022
@cpanato cpanato deleted the add-signing branch March 23, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants