Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): use the host network in docker example #395

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

prashant-shahi
Copy link
Contributor

What this PR does / why we need it: The docker container will use host network with no network isolation. That way, ct install can connect to k8s cluster running on host's machine.

Which issue this PR fixes: fixes #394

@cpanato cpanato merged commit c255a37 into helm:main Mar 14, 2022
ilmax pushed a commit to ilmax/chart-testing that referenced this pull request Mar 15, 2022
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Massimiliano Donini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker CLI example in README to run ct install returns error
3 participants