Add arm64 builds #351
Add arm64 builds #351
Conversation
Signed-off-by: Tyler Auerbeck <[email protected]>
Signed-off-by: Tyler Auerbeck <[email protected]>
tylerauerbeck
force-pushed
the
add-arm-build
branch
from
331d602 to
2b9e76c
Compare
|
hey @scottrigby can you confirm this looks good to you too ? |
|
Also thank you @tylerauerbeck 😄 |
|
CI failed. Can we check why? I'm not in a place to do that right now |
|
@scottrigby Yepp. On my list to dig into today. I'll let you know what I find. |
|
@scottrigby @paulczar Sorry for the delay on this one, but had some time to go back and take a look. I've been able to run this successfully on my own branch, which you can see here: release: https://github.com/tylerauerbeck/chart-testing/actions/runs/1498224439 Published images from the release workflow: https://quay.io/repository/tylerauerbeck/chart-testing?tab=tags |
|
@tylerauerbeck please sign the dco |
Signed-off-by: Tyler Auerbeck <[email protected]>
tylerauerbeck
force-pushed
the
add-arm-build
branch
from
285990a to
ff3fc7a
Compare
|
@cpanato Good catch. Signoff is there now. |
|
@scottrigby will merge ok? :) |
Signed-off-by: Tyler Auerbeck [email protected]
What this PR does / why we need it:
This PR adds the building and publishing of arm64 images to quay when a release is published.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #342Special notes for your reviewer:
This PR adds the publishing of arm64 images as well as amd64 images when a release is published. Because the same
goreleaserfunctionality is used in theciworkflow, we needed to add the buildx and qemu actions there as well.When a release is cut, there will now be a few images pushed to quay. For example, given a release of v3.4.5, you would end up with:
The last two would be the ones that would be useful to users and would direct them to the appropriate arch (and their manifests would just reference the underlying versions). Just wanted to call this out so it wasn't a surprise when this started to happen.