Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to gh-actions #297

Merged
merged 6 commits into from
Nov 24, 2020
Merged

Move to gh-actions #297

merged 6 commits into from
Nov 24, 2020

Conversation

davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Nov 6, 2020

Fixes #296

  • Release is now a workflow dispatch
  • Upgrade to helm v3.4.0

Note: For release to work the secrets for quay needs to be defined: QUAY_USERNAME + QUAY_PASSWORD
You can see the wf here: https://github.com/davidkarlsen/chart-testing/actions but I have a snag with the user initiated wf - it doesn't appear, which might be because I am on a fork or it's not defined in the default branch.


This change is Reviewable

Signed-off-by: David Karlsen <[email protected]>
Signed-off-by: David Karlsen <[email protected]>
@davidkarlsen davidkarlsen force-pushed the gh-actions branch 2 times, most recently from de59c39 to dcd3f3d Compare November 9, 2020 16:48
@davidkarlsen davidkarlsen marked this pull request as ready for review November 9, 2020 18:23
@davidkarlsen
Copy link
Member Author

@unguiculus @scottrigby ptal?

Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think it would be a good idea to have the same setup for both, chart-testing and chart-releaser. I went a different route for chart-releaser but don't really have strong opinions. Since chart-releaser's move to GitHub actions we've been having issues with Go modules because go.mod and go.sum would change during the build which I could not reproduce locally. This doesn't seem to be the case here. Have you experienced any such issues? If not, it may make more sense to proceed with your setup and adjust that of chart-releaser.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Signed-off-by: David Karlsen <[email protected]>
Signed-off-by: David Karlsen <[email protected]>
@davidkarlsen
Copy link
Member Author

In general, I think it would be a good idea to have the same setup for both, chart-testing and chart-releaser. I went a different route for chart-releaser but don't really have strong opinions. Since chart-releaser's move to GitHub actions we've been having issues with Go modules because go.mod and go.sum would change during the build which I could not reproduce locally. This doesn't seem to be the case here. Have you experienced any such issues? If not, it may make more sense to proceed with your setup and adjust that of chart-releaser.

I haven't had problems with go.{mod,sum} changing unexpectedly (or at all) - so I though I'd leave them in as a security-measure - we can remove them if we see any trouble down the lane.

@davidkarlsen
Copy link
Member Author

@unguiculus wdyt - can we merge it now?

@unguiculus unguiculus merged commit 9347b27 into helm:master Nov 24, 2020
@unguiculus
Copy link
Member

I disabled the old Circle CI project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Move from circle to gh-actions
3 participants