-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to gh-actions #297
Move to gh-actions #297
Conversation
5bb2d40
to
2446259
Compare
Signed-off-by: David Karlsen <[email protected]>
2446259
to
2c6d095
Compare
Signed-off-by: David Karlsen <[email protected]>
de59c39
to
dcd3f3d
Compare
Signed-off-by: David Karlsen <[email protected]>
Signed-off-by: David Karlsen <[email protected]>
@unguiculus @scottrigby ptal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think it would be a good idea to have the same setup for both, chart-testing and chart-releaser. I went a different route for chart-releaser but don't really have strong opinions. Since chart-releaser's move to GitHub actions we've been having issues with Go modules because go.mod and go.sum would change during the build which I could not reproduce locally. This doesn't seem to be the case here. Have you experienced any such issues? If not, it may make more sense to proceed with your setup and adjust that of chart-releaser.
Signed-off-by: David Karlsen <[email protected]>
Signed-off-by: David Karlsen <[email protected]>
I haven't had problems with go.{mod,sum} changing unexpectedly (or at all) - so I though I'd leave them in as a security-measure - we can remove them if we see any trouble down the lane. |
@unguiculus wdyt - can we merge it now? |
I disabled the old Circle CI project. |
Fixes #296
Note: For release to work the secrets for quay needs to be defined: QUAY_USERNAME + QUAY_PASSWORD
You can see the wf here: https://github.com/davidkarlsen/chart-testing/actions but I have a snag with the user initiated wf - it doesn't appear, which might be because I am on a fork or it's not defined in the default branch.
This change is