Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make home URL optional and support dependencies #260

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Make home URL optional and support dependencies #260

merged 2 commits into from
Aug 26, 2020

Conversation

minhdanh
Copy link
Contributor

What this PR does / why we need it:
home is optional according to Helm's docs: https://helm.sh/docs/topics/charts/

home: The URL of this projects home page (optional)

Chart.yaml also has optional declaration for dependencies:

dependencies: # A list of the chart requirements (optional)
  - name: The name of the chart (nginx)
    version: The version of the chart ("1.2.3")
    repository: The repository URL ("https://example.com/charts") or alias ("@repo-name")
    condition: (optional) A yaml path that resolves to a boolean, used for enabling/disabling charts (e.g. subchart1.enabled )
    tags: # (optional)
      - Tags can be used to group charts for enabling/disabling together
    enabled: (optional) Enabled bool determines if chart should be loaded
    import-values: # (optional)
      - ImportValues holds the mapping of source values to parent key to be imported. Each item can be a string or pair of child/parent sublist items.
    alias: (optional) Alias to be used for the chart. Useful when you have to add the same chart multiple times

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Signed-off-by: minhdanh <[email protected]>
@minhdanh minhdanh changed the title Update chart schema Make home URL optional and support dependencies Aug 15, 2020
repository: str()
condition: str(required=False)
tags: list(str(), required=False)
enabled: bool()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is optional according to https://helm.sh/docs/topics/charts/#the-chartyaml-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smlx Thanks. I've just updated that

Signed-off-by: minhdanh <[email protected]>

Make enabled optional
@minhdanh
Copy link
Contributor Author

@smlx Can we have this merged this soon?

Copy link
Contributor

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to, but I don't have a commit bit. That said, LGTM.

@unguiculus unguiculus merged commit 594c3b6 into helm:master Aug 26, 2020
@minhdanh minhdanh deleted the update-chart-schema branch August 27, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants