-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump helm to v2.16.0 #185
Bump helm to v2.16.0 #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the PR branch to dev-v2
per https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request
The dev-v2
branch is for ongoing chart-testing v2 maintenance. That will include bug fixes. master
is now for v3 work, and actively developed, including new features etc.
See #182 for more info about the branch/version change.
Also note there is a helm |
@EricLemieux I went ahead and changed the base branch for you, but now the changes from #183 are in this PR too since you initially created this PR branch from |
Changing the target branch changes the scope of this pr, because it now includes #183 Should I adjust as to only include the change I made? |
Chatting on Slack. That sounds good, will wait for update 👍 |
Signed-off-by: Eric Lemieux <[email protected]>
4810338
to
fc85bd4
Compare
Given the fixes going into Helm |
Given the concerns with |
What this PR does / why we need it:
Bumps the helm version to
v2.16.0
Special notes for your reviewer:
I saw that the
v3.0.0
pr is in progress, not sure if you were planning on continuing to support 2.x.x after that is merged.