Add option to skip upgrade testing of deleted/renamed values files #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows fixing previous chart versions in a single pull request without applying a major version bump to the chart version. Signed-off-by: Jacob LeGrone <[email protected]>
Signed-off-by: Jacob LeGrone <[email protected]>
Signed-off-by: Jacob LeGrone <[email protected]>
unguiculus
requested changes
Mar 24, 2019
Signed-off-by: Jacob LeGrone <[email protected]>
unguiculus
approved these changes
Mar 24, 2019
scottrigby
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
I like the short and sweet help text, so people know what this is about. Good catch re #130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See rationale in #130.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):Fixes #130
Special notes for your reviewer: