Add gofmt to CircleCI #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
requested changes
Feb 16, 2019
There was a problem hiding this comment.
@gliptak if you're interested in go formatting, would you mind working on a single PR to do the following?
- Configure Circle to fail builds if running gofmt against our source code produces a diff
- Fix any new errors by running
gofmt -w
|
@jlegrone I will work to update this PR as per above |
|
@jlegrone please review |
Signed-off-by: Gábor Lipták <[email protected]>
unguiculus
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták [email protected]