Skip to content

Commit

Permalink
fix: add unit to extra arg help message (#391)
Browse files Browse the repository at this point in the history
The help message for the --helm-extra-args config used an example without units,
which caused to fail the next chart-testing run if just copy-pasted.

Signed-off-by: Christopher Zell <[email protected]>
  • Loading branch information
ChrisKujawa authored Mar 14, 2022
1 parent a682e3e commit 4c4e8aa
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ct/cmd/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func addInstallFlags(flags *flag.FlagSet) {
the ID of a pull request. If not specified, the name of the chart is used`))
flags.String("helm-extra-args", "", heredoc.Doc(`
Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500"`))
(e.g. "--timeout 500s"`))
flags.Bool("upgrade", false, heredoc.Doc(`
Whether to test an in-place upgrade of each chart from its previous revision if the
current version should not introduce a breaking change according to the SemVer spec`))
Expand Down
2 changes: 1 addition & 1 deletion doc/ct_install.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ ct install [flags]
--excluded-charts strings Charts that should be skipped. May be specified multiple times
or separate values with commas
--helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500"
(e.g. "--timeout 500s"
--helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be
specified on a per-repo basis with an equals sign as delimiter
(e.g. 'myrepo=--username test --password secret'). May be specified
Expand Down
2 changes: 1 addition & 1 deletion doc/ct_lint-and-install.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ct lint-and-install [flags]
--excluded-charts strings Charts that should be skipped. May be specified multiple times
or separate values with commas
--helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500"
(e.g. "--timeout 500s"
--helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be
specified on a per-repo basis with an equals sign as delimiter
(e.g. 'myrepo=--username test --password secret'). May be specified
Expand Down

0 comments on commit 4c4e8aa

Please sign in to comment.