Add option to exclude deprecated charts

Adds a new configuration option that allows a user to exclude deprecated charts from testing. Signed-off-by: Eric Lemieux <[email protected]>
helm · Oct 1, 2020 · 46df4fb · 46df4fb
1 parent 3fc5a50
commit 46df4fb
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 2 deletions.
diff --git a/ct/cmd/root.go b/ct/cmd/root.go
@@ -74,6 +74,7 @@ func addCommonFlags(flags *pflag.FlagSet) {
 	flags.Bool("print-config", false, heredoc.Doc(`
 		Prints the configuration to stderr (caution: setting this may
 		expose sensitive data when helm-repo-extra-args contains passwords)`))
+	flags.Bool("exclude-deprecated", false, "Skip charts that are marked as deprecated")
 }
 
 func addCommonLintAndInstallFlags(flags *pflag.FlagSet) {

diff --git a/pkg/chart/chart.go b/pkg/chart/chart.go
@@ -295,7 +295,12 @@ func (t *Testing) processCharts(action func(chart *Chart) TestResult) ([]TestRes
 		if err != nil {
 			return nil, err
 		}
-		charts = append(charts, chart)
+
+		if t.config.ExcludeDeprecated && chart.yaml.Deprecated {
+			fmt.Printf("Chart %s is deprecated, and will be ignored due to the ExcludeDeprecated configuration option\n", chart.String())
+		} else {
+			charts = append(charts, chart)
+		}
 	}
 
 	fmt.Println()

diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -63,6 +63,7 @@ type Configuration struct {
 	SkipMissingValues     bool     `mapstructure:"skip-missing-values"`
 	Namespace             string   `mapstructure:"namespace"`
 	ReleaseLabel          string   `mapstructure:"release-label"`
+	ExcludeDeprecated 	  bool     `mapstructure:"exclude-deprecated"`
 }
 
 func LoadConfiguration(cfgFile string, cmd *cobra.Command, printConfig bool) (*Configuration, error) {

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -53,4 +53,5 @@ func loadAndAssertConfigFromFile(t *testing.T, configFile string) {
 	require.Equal(t, true, cfg.SkipMissingValues)
 	require.Equal(t, "default", cfg.Namespace)
 	require.Equal(t, "release", cfg.ReleaseLabel)
+	require.Equal(t, true, cfg.ExcludeDeprecated)
 }
diff --git a/pkg/config/test_config.json b/pkg/config/test_config.json
@@ -28,5 +28,6 @@
     "upgrade": true,
     "skip-missing-values": true,
     "namespace": "default",
-    "release-label": "release"
+    "release-label": "release",
+    "exclude-deprecated": true
 }
diff --git a/pkg/config/test_config.yaml b/pkg/config/test_config.yaml
@@ -24,3 +24,4 @@ upgrade: true
 skip-missing-values: true
 namespace: default
 release-label: release
+exclude-deprecated: true